anton-vinogradov commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3476132012
##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -25,6 +25,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<ignite.version>2.19.0-SNAPSHOT</ignite.version>
+ <ignite.extensions.version>1.0.0</ignite.extensions.version>
Review Comment:
Minor, but worth flagging here: ignite-extensions modules are released
**independently** of each other (and of core), so a single
`ignite.extensions.version` property is a latent trap — it only works because
`ignite-aws-ext`, `ignite-azure-ext`, `ignite-gce-ext` and
`ignite-zookeeper-ip-finder-ext` all happen to sit at `1.0.0` today. As soon as
one of them publishes a new release, you're either stuck on it for all four or
silently compiling against a stale one. Per-artifact version properties (or at
least a comment stating the shared value is coincidental) will age better.
##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -67,12 +68,47 @@
<artifactId>ignite-zookeeper</artifactId>
<version>${ignite.version}</version>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>ignite-aws-ext</artifactId>
+ <version>${ignite.extensions.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>ignite-azure-ext</artifactId>
+ <version>${ignite.extensions.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>ignite-cloud</artifactId>
+ <version>2.13.0</version>
+ </dependency>
Review Comment:
This is the one dependency that isn't a real extension artifact:
`ignite-cloud-ext` was never published to Maven Central, so
`ignite-cloud:2.13.0` is a deliberate legacy fallback (the only resolvable
artifact that still ships `TcpDiscoveryCloudIpFinder`). Please record that in
the POM so the next reader doesn't "fix" it by bumping the version or switching
to a non-existent `ignite-cloud-ext`:
```suggestion
<dependency>
<groupId>${project.groupId}</groupId>
<!-- ignite-cloud-ext (the ignite-extensions successor of this
module) is not yet
published to Maven Central, so we deliberately fall back to
the last released
legacy ignite-cloud artifact, which still ships
TcpDiscoveryCloudIpFinder.
Revisit once ignite-cloud-ext is released (dev-list:
https://lists.apache.org/thread/d214wbsp84gm6sc93woctf3q68dhrsch). -->
<artifactId>ignite-cloud</artifactId>
<version>2.13.0</version>
</dependency>
```
Also please double-check `2.13.0` actually compiles against
`ignite-core:2.19.0-SNAPSHOT` — that's a wide gap on the discovery IP-finder
SPI, and it's the dependency most likely to break the gate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
