zstan commented on code in PR #13225:
URL: https://github.com/apache/ignite/pull/13225#discussion_r3490116681
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteSqlFunctions.java:
##########
@@ -119,15 +119,15 @@ public static BigDecimal toBigDecimal(boolean val, int
precision, int scale) {
}
/** CAST(VARCHAR AS DECIMAL). */
- public static BigDecimal toBigDecimal(String s, int precision, int scale) {
+ public static @Nullable BigDecimal toBigDecimal(String s, int precision,
int scale) {
Review Comment:
all such changes are out of scope of initial issue activity, all these
changes are only my own contribution and can be requests to be rolled back by
reviewer as it enhances readability of initial issue. So i prefer not to change
it, you can change it yourself if it important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
