alex-plekhanov commented on code in PR #13298:
URL: https://github.com/apache/ignite/pull/13298#discussion_r3518006299
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java:
##########
@@ -3134,13 +3133,16 @@ private TxRecoveryInitRunnable(ClusterNode node) {
sendTxSalvage(tx, evtNodeId);
}
+ Supplier<Boolean> fullSyncedOp = () ->
tx.writeEntries().stream().map(e ->
+
cctx.cacheContext(e.cacheId())).allMatch(GridCacheContext::syncCommit);
Review Comment:
`Supplier` is redundant, we can use this call directly.
Logic is inconsistent with `syncMode` logic (in `syncMode` `FULL_SYNC` is
returned if **any** of cache have `FULL_SYNC` mode, but in current statement
`FULL_SYNC` is returned if **all** caches have `FULL_SYNC` mode)
Let's use loop instead of streams.
Let's describe in comment why we can't use `deriveSyncMode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
