zstan commented on code in PR #13274:
URL: https://github.com/apache/ignite/pull/13274#discussion_r3531188081
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementor.java:
##########
@@ -339,23 +337,23 @@ public LogicalRelImplementor(
List<RelFieldCollation> leftCollations =
rel.leftCollation().getFieldCollations();
List<RelFieldCollation> rightCollations =
rel.rightCollation().getFieldCollations();
- ImmutableBitSet allowNulls = rel.allowNulls();
- ImmutableBitSet.Builder collsAllowNullsBuilder =
ImmutableBitSet.builder();
+ ImmutableList<Boolean> nullExclusions =
rel.analyzeCondition().nullExclusionFlags;
+ ImmutableBitSet.Builder nullCompAsEqual = ImmutableBitSet.builder();
int lastCollField = -1;
for (int c = 0; c < Math.min(leftCollations.size(),
rightCollations.size()); ++c) {
RelFieldCollation leftColl = leftCollations.get(c);
RelFieldCollation rightColl = rightCollations.get(c);
- collsAllowNullsBuilder.set(c);
+ nullCompAsEqual.set(c);
for (int p = 0; p < pairsCnt; ++p) {
IntPair pair = joinPairs.get(p);
if (pair.source == leftColl.getFieldIndex() && pair.target ==
rightColl.getFieldIndex()) {
lastCollField = c;
- if (!allowNulls.get(p)) {
- collsAllowNullsBuilder.clear(c);
+ if (!nullExclusions.get(p)) {
Review Comment:
no, i understand what you mean, "not" is changed in comparator
implementation side, or if you about namings - let\`s discuss it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
