shishkovilja commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3531354303
##########
modules/core/src/test/resources/codegen/TestMarshallableMessage.java:
##########
@@ -33,13 +34,11 @@ public class TestMarshallableMessage implements
MarshallableMessage {
@Order(2)
byte[] cstDataBytes;
- /** {@inheritDoc} */
- @Override public void prepareMarshal(Marshaller marsh) throws
IgniteCheckedException {
+ @Override public void marshal(Marshaller marsh) throws
IgniteCheckedException {
Review Comment:
I suggest to revert this change. We can perfrorm it in another PR.
##########
modules/core/src/test/resources/codegen/TestMarshallableMessage.java:
##########
@@ -33,13 +34,11 @@ public class TestMarshallableMessage implements
MarshallableMessage {
@Order(2)
byte[] cstDataBytes;
- /** {@inheritDoc} */
- @Override public void prepareMarshal(Marshaller marsh) throws
IgniteCheckedException {
+ @Override public void marshal(Marshaller marsh) throws
IgniteCheckedException {
cstDataBytes = U.marshal(marsh, cstData);
}
- /** {@inheritDoc} */
- @Override public void finishUnmarshal(Marshaller marsh, ClassLoader
clsLdr) throws IgniteCheckedException {
+ @Override public void unmarshal(Marshaller marsh, ClassLoader clsLdr)
throws IgniteCheckedException {
Review Comment:
I suggest to revert this change. We can perfrorm it in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
