anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3579560664
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManagerImpl.java:
##########
@@ -995,13 +995,18 @@ private long allocateForTree() throws
IgniteCheckedException {
assert info.ttl() == TTL_ETERNAL : info.ttl();
- batch.add(new DataRowCacheAware(info.key(),
- info.value(),
- info.version(),
- part.id(),
- info.expireTime(),
- info.cacheId(),
- grp.storeCacheIdInDataPage()));
+ try {
+ batch.add(new DataRowCacheAware(info.key(),
+ info.value(),
+ info.version(),
+ part.id(),
+ info.expireTime(),
+ info.cacheId(),
+ grp.storeCacheIdInDataPage()));
+ }
+ catch (IllegalStateException th) {
+ assert ctx.cacheContext(grp.groupId()) == null; // Ignoring
removed cache entries.
+ }
Review Comment:
Found while chasing a CI failure: with assertions off (production) the old
form silently swallowed *every* `IllegalStateException` here — including ones
that aren't the removed-cache race — masking the real error. The new form keeps
the deliberate ignore for the race and propagates the rest; under `-ea` (all
test runs) the strictness is identical to the assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
