nizhikov commented on code in PR #13416:
URL: https://github.com/apache/ignite/pull/13416#discussion_r3681957199
##########
modules/nio/src/main/java/org/apache/ignite/plugin/extensions/communication/MessageFactory.java:
##########
Review Comment:
Thanks, fixed
##########
modules/codegen/src/main/java/org/apache/ignite/internal/MessageSerializerGenerator.java:
##########
@@ -222,6 +226,23 @@ private void generateMethod(List<String> code,
List<VariableElement> fields, boo
code.add(indentedLine("}"));
}
+ /** Writes {@code MessageSerializer#newInstance()} method body. */
+ private void writeNewInstance(Writer writer) throws IOException {
+ writer.write(TAB + "/** {@inheritDoc} */");
+ writer.write(NL);
+ writer.write(TAB + "@Override public final " + type.getSimpleName() +
" createMessage() {");
+ writer.write(NL);
+
+ if (type.getQualifiedName().contentEquals(GRID_H2_NULL))
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
