wernerdv commented on code in PR #13409:
URL: https://github.com/apache/ignite/pull/13409#discussion_r3704052526
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java:
##########
@@ -821,30 +806,26 @@ private String
validatePayload(DistributedMetaStorageJoiningNodeData joiningData
DistributedMetaStorageJoiningNodeData joiningData =
discoData.joiningNodeData();
- DistributedMetaStorageVersion remoteVer = joiningData.ver;
-
lock.readLock().lock();
try {
DistributedMetaStorageVersion locVer = ver;
- if (remoteVer.id() >= locVer.id()) {
- Serializable nodeData = new
DistributedMetaStorageClusterNodeData(remoteVer, null, null, null);
+ if (joiningData.dVerId >= locVer.id()) {
+ var rmtVer = new
DistributedMetaStorageVersion(joiningData.dVerId, joiningData.dVerHash);
Review Comment:
rmtVer is created only so that the DistributedMetaStorageClusterNodeData
constructor can immediately decompose it back into dVerId/dVerHash.
Not critical, but it can be eliminated by adding a constructor overload with
primitives (long dVerId, long dVerHash, ...).
Up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
