tkalkirill commented on code in PR #13311:
URL: https://github.com/apache/ignite/pull/13311#discussion_r3718752963
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/LimitExecutionTest.java:
##########
@@ -78,10 +79,10 @@ private void checkLimitSort(int offset, int fetch) {
RootNode<Object[]> rootNode = new RootNode<>(ctx, rowType);
- SortNode<Object[]> sortNode = new SortNode<>(ctx, rowType,
F::compareArrays, () -> offset,
- fetch == 0 ? null : () -> fetch);
+ SortNode<Object[]> sortNode = new SortNode<>(ctx, rowType,
F::compareArrays, offset,
+ fetch == 0 ? -1 : fetch);
Review Comment:
Replace these methods with constants declared separately in each
corresponding class. `LimitNode` and `SortNode` should each own the constants
that define their internal state instead of sharing them through a common
accessor. This project does not use methods to expose fixed constant values, so
keep the implementation consistent with the existing project style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
