vldpyatkov commented on code in PR #13366:
URL: https://github.com/apache/ignite/pull/13366#discussion_r3720372516
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/AbstractBasicIntegrationTest.java:
##########
@@ -269,20 +271,34 @@ protected List<List<?>> sqlAsRoot(IgniteEx ignite, String
sql) throws Exception
/** */
protected List<List<?>> sql(IgniteEx ignite, String sql, Object... params)
{
- // {@code sql} can contain more than one query.
- List<FieldsQueryCursor<List<?>>> allCurs =
queryProcessor(ignite).query(queryContext(), "PUBLIC", sql, params);
+ Transaction tx = ignite.transactions().tx();
Review Comment:
I like this change. Moreover, I think finally we understand that the
AbstractBasicIntegrationTest.java is not the best base class.
Probably, we will make a refactoring in the future in order to it uses a
public APY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
