anton-vinogradov commented on code in PR #13427:
URL: https://github.com/apache/ignite/pull/13427#discussion_r3722244672
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryInfo.java:
##########
@@ -193,9 +190,9 @@ public int marshalledSize(CacheObjectContext ctx) throws
IgniteCheckedException
return SIZE_OVERHEAD + size;
}
- // TODO IGNITE-28920: move the expireTime rebase out of the marshalling
hooks.
+ // TODO IGNITE-28920: move the expireTime rebase out of the
self-marshalling step.
Review Comment:
Good catch, but only half of IGNITE-28920 is done here.
The ticket asks for two things:
1. "drop the `MarshallableMessage` interface from `GridCacheEntryInfo`" —
this PR does it. The class now implements `SelfMarshallingMessage`, whose
methods take no `Marshaller`, so the class no longer claims to carry marshalled
payload.
2. "move the expireTime rebase out of the marshalling hooks" — this PR does
**not** do it. The rebase still runs inside the message; only the hook changed
its name (`marshal(Marshaller)` -> `selfMarshal()`).
So the TODO is still needed, and I reworded it to name the remaining part:
```java
// TODO IGNITE-28920: the rebase still runs inside the message;
// move it to the code filling and reading the entry.
```
I can also narrow the ticket description to part 2, so that the ticket and
the TODO say the same thing. Tell me if you want that and I will update the
ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
