tkalkirill commented on code in PR #13375:
URL: https://github.com/apache/ignite/pull/13375#discussion_r3729867941
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementor.java:
##########
@@ -571,7 +576,7 @@ private boolean hasExchange(RelNode rel) {
ctx,
rowType,
idxBndRel.first() ? cmp : cmp.reversed(),
- 0,
+ SortNode.OFFSET_DEFAULT,
Review Comment:
I see your point. My intention is to express the semantics of this
positional argument: no offset is specified here. The reader does not need to
look up the constant value unless implementation details matter, while 0 shows
the value but not the intent. It also keeps this call consistent with the
defaults defined by `SortNode`, so I’d prefer to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
