petrov-mg commented on code in PR #13456:
URL: https://github.com/apache/ignite/pull/13456#discussion_r3747968846
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -1597,6 +1600,16 @@ else if (U.millisSinceNanos(joinStartNanos) >
spi.joinTimeout)
errs.add(e);
+ if (e instanceof UnsupportedNodeVersionException) {
+ LT.error(log, e, "Failed to initialize a connection with
the remote node. The remote node is running" +
+ " components with an incompatible versions, so the
nodes cannot agree on serialization protocol" +
+ " [rmtAddr=" + addr + ']');
Review Comment:
Regarding the separate catch block: the issue is that in places like this we
don’t just log the exception and rethrow it—we also close sockets, call
onException, and perform other cleanup.
I’m concerned that duplicating the exception-handling logic could introduce
problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
