zstan commented on code in PR #13366:
URL: https://github.com/apache/ignite/pull/13366#discussion_r3748181900
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/IgnitePlanner.java:
##########
@@ -423,6 +423,15 @@ public String dump() {
return w.toString();
}
+ /** Returns whether the SELECT changes row cardinality using aggregation.
*/
+ @SuppressWarnings("deprecation")
+ public boolean isAggregate(SqlSelect select) {
+ SqlValidator validator = validator();
+
+ return validator.isAggregate(select)
+ || (select.getOrderList() != null &&
validator.isAggregate(select.getOrderList()));
Review Comment:
Can you initialize
aggFinder = new AggFinder(opTab, false, true, false, null, nameMatcher);
check SqlValidatorImpl.java -> line 337 and use it instead of deprecated
code ?
Or
org.apache.calcite.sql.validate.SqlValidatorImpl#isNestedAggregateWindow
they initializes it\`s own AggFinder, can you make the same instead of
deprecation usage ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
