anton-vinogradov commented on PR #13440: URL: https://github.com/apache/ignite/pull/13440#issuecomment-5239417345
The wire format change is intentional and is the point of this ticket, so here is what actually changes and what does not. **Changed** - four messages carry the deployment as one descriptor instead of four flat fields (`deployMode`, `userVersion`, `classLoaderId`, `participants`): | message | `@Order` fields | |---|---| | `GridJobExecuteRequest` | 25 → 22 | | `DataStreamerRequest` | 16 → 13 | | `GridIoUserMessage` | 7 → 4 | | `GridEventStorageRequest` | 7 → 4 | **Not changed**, though the check lists them: - `StartRequestData` - 8 fields before and after; only field visibility and the code reading them moved. - `GridCacheMessage` - the type of an existing field was renamed, the field itself stays. - `GridDeploymentInfoBean` / `GridDeploymentInfoMessage` - one class renamed under IGNITE-28967. Its own fields and its `directType` are untouched: the registration keeps its place in `CoreMessagesProvider`, and `META-INF/classnames.properties` is updated. Rolling upgrade: this lands before 2.19 is released, which is the window such changes are meant for - the same reasoning as in IGNITE-28940. Between 2.18 and 2.19 these four messages are not compatible, deliberately. One note on the check itself: `GridJobExecuteRequest` changes the most here and is **missing** from the list above, while three classes that do not change the format are listed. That matches the detection defects filed as IGNITE-28966 - the check is blind to messages in its own package and reports files whose change is not on the wire. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
