zstan commented on code in PR #13455:
URL: https://github.com/apache/ignite/pull/13455#discussion_r3749233418
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/MergeJoinNode.java:
##########
@@ -238,27 +237,6 @@ protected boolean rightFinished(boolean
withMaterialization) {
&& (!withMaterialization || rightMaterialization == null);
}
- /** */
- protected boolean checkJoinFinished() throws Exception {
Review Comment:
I think this approach is not acceptable for all join algo, as you suggest,
you can try it by yourself ... re-phrase: i think we can\`t implement it as it
was before cause it behavior is depend of join type used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
