anton-vinogradov commented on code in PR #13454: URL: https://github.com/apache/ignite/pull/13454#discussion_r3751961711
########## modules/core/src/main/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerBuiltInUpdater.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.datastreamer; + +import org.apache.ignite.stream.StreamReceiver; +import org.jetbrains.annotations.Nullable; + +/** + * The built-in updaters. Every node has them, so a request names the one it needs instead of carrying a serialized + * copy. The message naming one is built on demand: a node that streams with a custom receiver builds none. Review Comment: Dropped — the class javadoc is just what the constants are now. ########## modules/core/src/main/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerBuiltInUpdater.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.datastreamer; + +import org.apache.ignite.stream.StreamReceiver; +import org.jetbrains.annotations.Nullable; + +/** + * The built-in updaters. Every node has them, so a request names the one it needs instead of carrying a serialized + * copy. The message naming one is built on demand: a node that streams with a custom receiver builds none. + */ +enum DataStreamerBuiltInUpdater { + /** {@link DataStreamerImpl#ISOLATED_UPDATER}. */ + ISOLATED(DataStreamerImpl.ISOLATED_UPDATER), + + /** {@link DataStreamerCacheUpdaters#individual()}. */ + INDIVIDUAL(DataStreamerCacheUpdaters.individual()), + + /** {@link DataStreamerCacheUpdaters#batched()}. */ + BATCHED(DataStreamerCacheUpdaters.batched()), + + /** {@link DataStreamerCacheUpdaters#batchedSorted()}. */ + BATCHED_SORTED(DataStreamerCacheUpdaters.batchedSorted()); + + /** */ + private final StreamReceiver<?, ?> updater; + + /** */ + private DataStreamerReceiverMessage msg; + + /** @param updater Updater this constant stands for. */ + DataStreamerBuiltInUpdater(StreamReceiver<?, ?> updater) { + this.updater = updater; + } + + /** @return Updater of this node. */ + StreamReceiver<?, ?> updater() { + return updater; + } + + /** @return Message naming this updater; one per constant, as a built-in updater never changes. */ + DataStreamerReceiverMessage message() { + if (msg == null) Review Comment: Agreed, nothing is kept: ```java /** @return New message naming this updater. */ DataStreamerReceiverMessage message() { return new DataStreamerReceiverMessage(this); } ``` No shared field, so no publication to reason about. The streamer keeps the message it builds when a receiver is set, so the only allocation left is one per batch while the default receiver is in use. Reading the receiver itself no longer goes through a message at all — `allowOverwrite()` is asked once per entry, and that path now compares against `ISOLATED_UPDATER` directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
