tkalkirill commented on code in PR #13464:
URL: https://github.com/apache/ignite/pull/13464#discussion_r3781530115
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementor.java:
##########
@@ -1072,6 +1077,11 @@ private long validateAndGetFetchOffsetParams(RexNode
node, String op) {
Supplier<Object> scalar = expressionFactory.execute(node);
Object param = scalar.get();
+ if (param == null && !(node instanceof RexDynamicParam)) {
Review Comment:
If this check is commented out, the `FETCH FIRST (NULLIF(?, 1))` assertion
starts failing because it gets an incorrect dynamic parameter type error
instead of an illegal FETCH value. The `RexDynamicParam` exclusion preserves
the existing error for a bare `FETCH FIRST ?` with a `NULL` parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
