Vladsz83 commented on code in PR #13462: URL: https://github.com/apache/ignite/pull/13462#discussion_r3783646959
########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java: ########## @@ -18,13 +18,19 @@ package org.apache.ignite.internal.processors.cache.verify; import java.io.Serializable; +import org.apache.ignite.internal.JdkMarshalled; import org.apache.ignite.internal.Marshalled; import org.apache.ignite.internal.Order; import org.apache.ignite.internal.util.tostring.GridToStringInclude; import org.apache.ignite.internal.util.typedef.internal.S; import org.apache.ignite.plugin.extensions.communication.Message; -/** Represents committed transactions hash for a pair of nodes. */ +/** + * Represents committed transactions hash for a pair of nodes. + * <p> + * Travels both transports inside the result of a snapshot check, and carries a user consistent id. Review Comment: Let's say what the transports ########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/StoredCacheData.java: ########## @@ -42,7 +43,10 @@ * in order to be serialization wise agnostic to further additions or removals of fields. * <p> * All changes must be made with the respect of RU rules. + * <p> + * Travels both transports: by discovery when a cache starts, by communication when a snapshot is restored. Review Comment: Same. Upper-cased Discovery and Connunication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
