sergey-chugunov-1985 commented on code in PR #13494:
URL: https://github.com/apache/ignite/pull/13494#discussion_r3828241489
##########
modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerTest.java:
##########
@@ -435,7 +437,7 @@ public void testIdleVerifyCancelOnCheckpoint() throws
Exception {
}, false);
}
- /** */
+ /** TODO : revise in https://issues.apache.org/jira/browse/IGNITE-29002 */
Review Comment:
```suggestion
/** TODO: revise in https://issues.apache.org/jira/browse/IGNITE-29002 */
```
##########
modules/core/src/main/java/org/apache/ignite/internal/management/cache/VerifyBackupPartitionsTask.java:
##########
@@ -94,16 +96,17 @@ public class VerifyBackupPartitionsTask extends
ComputeTaskAdapter<CacheIdleVeri
/** Checkpoint reason. */
public static final String CP_REASON = "VerifyBackupPartitions";
- /** Shared for tests. */
- public static Supplier<ExecutorService> poolSupplier =
IgniteForkJoinPool::commonPool;
+ /**
+ * Only for tests. Overrides the default pool.
+ * TODO : remove in https://issues.apache.org/jira/browse/IGNITE-29002
Review Comment:
```suggestion
* TODO: remove in https://issues.apache.org/jira/browse/IGNITE-29002
```
##########
docs/_docs/tools/control-script.adoc:
##########
@@ -696,6 +696,17 @@ To cancel a running `idle_verify` operation, use the
`--cancel` argument:
control.sh --cache idle_verify --cancel
----
+[NOTE]
+====
+[discrete]
+`idle_verify` command uses also own utility thread pool of default size `Total
CPUs - 2` with the minimum of `4` threads.
Review Comment:
```suggestion
`idle_verify` command uses its own utility thread pool of default size
`Total CPUs - 2` with the minimum of `4` threads.
```
##########
docs/_docs/tools/control-script.adoc:
##########
@@ -696,6 +696,17 @@ To cancel a running `idle_verify` operation, use the
`--cancel` argument:
control.sh --cache idle_verify --cancel
----
+[NOTE]
+====
+[discrete]
+`idle_verify` command uses also own utility thread pool of default size `Total
CPUs - 2` with the minimum of `4` threads.
+The pool size might be adjusted at node start with the system property
Review Comment:
```suggestion
The pool size might be adjusted at node startup with the system property
```
##########
modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerTest.java:
##########
@@ -456,11 +458,11 @@ public void
testIdleVerifyCancelBeforeCalcPartitionHashStarted() throws Exceptio
}
};
- VerifyBackupPartitionsTask.poolSupplier = () -> pool;
+ VerifyBackupPartitionsTask.EXECUTOR_SERVICE = pool;
}, false);
}
- /** */
+ /** TODO : revise in https://issues.apache.org/jira/browse/IGNITE-29002 */
Review Comment:
```suggestion
/** TODO: revise in https://issues.apache.org/jira/browse/IGNITE-29002 */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
