tkalkirill commented on code in PR #13225:
URL: https://github.com/apache/ignite/pull/13225#discussion_r3860940444
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteSqlFunctions.java:
##########
@@ -119,15 +119,15 @@ public static BigDecimal toBigDecimal(boolean val, int
precision, int scale) {
}
/** CAST(VARCHAR AS DECIMAL). */
- public static BigDecimal toBigDecimal(String s, int precision, int scale) {
+ public static @Nullable BigDecimal toBigDecimal(String s, int precision,
int scale) {
Review Comment:
Nothing is wrong with the runtime behavior. The problem is that this is an
unrelated and incomplete nullability change. `@Nullable` is part of the method
contract and is used by static analysis, not merely a readability improvement.
These methods explicitly accept null, but only their return types were
annotated. If annotating the parameters is out of scope, then the return-type
annotations are out of scope as well. Please revert them; a complete and
consistent nullability cleanup can be submitted separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
