vldpyatkov commented on code in PR #13545:
URL: https://github.com/apache/ignite/pull/13545#discussion_r3925536320
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/IgniteSchema.java:
##########
@@ -143,6 +150,17 @@ public SchemaPlus register(SchemaPlus parent,
FrameworkConfig frameworkCfg) {
viewMap.forEach((name, sql) -> newSchema.add(name, new
ViewTableMacroImpl(sql, newSchema, frameworkCfg)));
+ registerDualTableIfSupported(newSchema, frameworkCfg);
+
return newSchema;
}
+
+ /** */
+ private static void registerDualTableIfSupported(SchemaPlus schema,
FrameworkConfig frameworkCfg) {
+ if (frameworkCfg != null &&
frameworkCfg.getParserConfig().conformance().isSupportedDualTable()
Review Comment:
Wouldn't it be more appropriate to use the validator conformance here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]