zstan commented on code in PR #13543:
URL: https://github.com/apache/ignite/pull/13543#discussion_r3934303872
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/ConverterUtils.java:
##########
@@ -111,6 +116,9 @@ else if (targetType == java.sql.Timestamp.class) {
if (isA(fromType, Primitive.LONG))
return
Expressions.call(BuiltInMethod.INTERNAL_TO_TIMESTAMP.method, operand);
}
+ else if (targetType == byte[].class && fromType == ByteString.class)
Review Comment:
dead code
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/ConverterUtils.java:
##########
@@ -74,6 +76,9 @@ else if (fromType == java.sql.Timestamp.class) {
else if (targetType == Long.class)
return
Expressions.call(BuiltInMethod.TIMESTAMP_TO_LONG_OPTIONAL.method, operand);
}
+ else if (fromType == byte[].class && targetType == ByteString.class)
Review Comment:
dead code
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteTableFunction.java:
##########
@@ -100,6 +106,11 @@ public static IgniteTableFunction create(Method method,
Class<?>[] colTypes, Str
return Iterable.class;
}
+ /** {@inheritDoc} */
+ @Override public List<FunctionParameter> getParameters() {
Review Comment:
need to be moved into abstracn cause `IgniteScalarFunction#getParameters` do
the same as i can see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
