maksaska opened a new pull request, #13575:
URL: https://github.com/apache/ignite/pull/13575
The MBean name of a metric registry was spelled out at every call site, and
every one of them read an attribute as next(mbean.Attr).strip(). Both are now
in one place:
* metric_registry_pattern(group, name) builds the name pattern, honouring
the two rules the JMX exporter follows - the registry name is split at its
FIRST dot, and the tail is quoted only when it is not purely alphanumeric. The
pattern the rebalance metrics used, '.*group=cacheGroups.*name="%s"', required
the quotes unconditionally and so could not find the registry of an
alphanumeric cache group name at all.
* The pattern ends at the end of the line. 'name' sorts last of an MBean
name's properties, so without the anchor a registry whose name is a prefix of
another one ("myCache" against "myCacheV2") matched the wrong bean.
* JmxMBean.value()/bool_value() read a single valued attribute.
* cache_mbean()/cache_group_mbean() expose the two registries a test asks
for.
Also documents why IgniteAwareService.await_rebalance() builds a JmxClient
of its own instead of the node's memoized one: the memoized client holds the
pid of the incarnation it was built for, and await_rebalance() runs right after
a restart.
check_jmx_utils.py covers the pattern, including both cases that used to be
wrong.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where
`XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers
list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot
- Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance
2](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to
Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation
rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity
Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email [email protected] or ask anу advice
on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
