tkalkirill commented on code in PR #13569:
URL: https://github.com/apache/ignite/pull/13569#discussion_r4016013993
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/type/OtherType.java:
##########
@@ -29,21 +28,12 @@ public OtherType(boolean nullable) {
/** {@inheritDoc} */
@Override protected void generateTypeString(StringBuilder sb, boolean
withDetail) {
- sb.append("OTHER");
+ // The digest must differ from Calcite's OTHER to keep the types
distinct in its shared type cache.
+ sb.append(withDetail ? "IGNITE_OTHER" : "OTHER");
Review Comment:
I’d keep the conditional. `withDetail=true` builds the unique digest, where
`IGNITE_OTHER` prevents the cache collision. With false, it produces the
regular type name, which `IgniteTypeCoercion` also uses when constructing
`CAST` expressions. Keeping `OTHER` there preserves the existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
