Vladsz83 commented on code in PR #13577:
URL: https://github.com/apache/ignite/pull/13577#discussion_r4095525253


##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotSelfTest.java:
##########
@@ -615,6 +615,43 @@ public void testSnapshotExistsException() throws Exception 
{
         waitForEvents(EVT_CLUSTER_SNAPSHOT_STARTED, 
EVT_CLUSTER_SNAPSHOT_FAILED);
     }
 
+    /**
+     * Tests that snapshot create detects concurrent deletion, or detects 
still existing snapshot or successfully
+     * proceeds if snapshot already deleted.
+     */
+    @Test
+    public void testConcurrentSnapshotDeleteOperation() throws Exception {

Review Comment:
   This test does cover concurrent snapshot creation operation which cannot 
start. Of course, we create cnapshot. With an unexisting snapshot the deletion 
doesn't start at all - the metas aren't found. There will be no cuncurrency, 
The opposite tests (when deletion cannot start) are in 
`IgniteClusterSnapshotDeleteTest`. For example, 
`testSnapshotDeleteWhenCreateInProgress`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to