Vladsz83 commented on code in PR #13577:
URL: https://github.com/apache/ignite/pull/13577#discussion_r4303612992
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/AbstractSnapshotSelfTest.java:
##########
@@ -148,6 +153,9 @@ public abstract class AbstractSnapshotSelfTest extends
GridCommonAbstractTest {
protected static final int PAGE_SIZE =
IgniteSystemProperties.getInteger(IGNITE_DEFAULT_DATA_STORAGE_PAGE_SIZE,
DFLT_PAGE_SIZE);
+ /** */
+ protected static boolean caseInsensitiveFs;
Review Comment:
1) “You compute snap name according FS sens.” needs clarification. What do
you mean by “compute”?
2) “You push this name as lambdas into
doConcurrentSnapshotOperationWhenDeletionIsActive”: this looks like normal
practice to me, across all the tests, across the snapshot tests and in Ignite’s
codebase in general. We use lambdas often, so there’s nothing unusual here.
3) “doConcurrentSnapshotOperationWhenDeletionIsActive - use `SNAPSHOT_NAME`
without FS sens”: true. The idea is to use this knowledge.
4) “Remove caseInsensitiveFs at all and use snap name only in lower case.”
“Extend (seems it need to be: GridCommandHandlerDeleteSnapshotTest) with case I
mention above in this discussion, wdyt?”
`caseInsensitiveFs` was introduced precisely so that we don’t have to write
tests like that. We would need such tests for snapshot deletion-creation,
deletion-restoration, deletion-checking and, likewise, for creation-deletion,
restoration-deletion, checking-deletion With `caseInsensitiveFs` we reuse the
existing tests we need however instead of writing all of these separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
