Copilot commented on code in PR #13666:
URL: https://github.com/apache/ignite/pull/13666#discussion_r4310738537
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/CoreFeatureRegistry.java:
##########
@@ -93,4 +93,7 @@
public class CoreFeatureRegistry {
/** */
public static final IgniteFeature ROLLING_UPGRADE_FEATURE = new
IgniteCoreFeature(0);
+
+ /** */
+ public static final IgniteFeature SNAPSHOT_LIST_FEATURE = new
IgniteCoreFeature(1);
Review Comment:
Feature ID 1 is already assigned to `VER_2_19_0_ID_1_FEATURE` in the
existing 2.19.0–2.19.3 release registries
(`modules/core/src/test/java/org/apache/ignite/internal/processors/rollingupgrade/feature/TestIgniteReleaseFeatures_2_19_3.java:26`).
Feature IDs are the compatibility identifiers, so reusing it makes a 2.19.3
node appear to support `SNAPSHOT_LIST_FEATURE` even though it has no list task,
allowing the command during rolling upgrade. Allocate a new unused
monotonically increasing ID and update the release feature definitions/table
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
