NSAmelchev commented on PR #13709:
URL: https://github.com/apache/ignite/pull/13709#issuecomment-6287339079
A few small suggestions:
1. `BinaryReaderExImpl`: the remaining `BinaryUtils.binariesFactory.*` calls
(L3209, L3215, L3335, L3348, L3429, L3437, L3439) can call the constructors
directly too, as L372 already does. After that
`BinariesFactory#binaryOffheapObject` has no callers and can be removed.
2. `BinaryReaderExImpl`: how about `public final class` instead of `final`
on 144 methods? The class has no subclasses, and there's no JIT benefit either
way: HotSpot already inlines methods that nothing overrides (CHA).
3. `ClusterMetricsSnapshotSerializeCompatibilityTest`: the local
`unmarshalZip` duplicates `U.unmarshal(Marshaller, InputStream, ClassLoader)`.
Three lines in the test are enough (plus `throws Exception`):
```java
ZipInputStream in = new ZipInputStream(new
ByteArrayInputStream(zipMarshal));
in.getNextEntry();
HashMap<Integer, CacheMetricsSnapshot> unmarshalMetrics =
U.unmarshal(marshaller, in, null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
