XianReallyHot-ZZH opened a new pull request, #13715:
URL: https://github.com/apache/ignite/pull/13715

   Ticket: IGNITE-11355
   
   ## What changes
   
   The inline size recommendation logged by `InlineRecommender` for primary key 
/ affinity key indexes previously suggested only the global system property. It 
now also mentions the per-cache API, which scopes the change to a single cache:
   
   ```
   Indexed columns of a row cannot be fully inlined into index what may lead to 
slowdown due to additional data page reads, increase index inline size if 
needed (set system property IGNITE_MAX_INDEX_PAYLOAD_SIZE with recommended size 
(be aware it will be used by default for all indexes without explicit inline 
size), or set CacheConfiguration.sqlIndexMaxInlineSize with recommended size 
for this cache) [...]
   ```
   
   The recommendation for secondary indexes (INLINE_SIZE option / 
QuerySqlField.inlineSize / QueryIndex.inlineSize) is unchanged.
   
   ## Testing
   
   New `InlineRecommenderSelfTest` (modules/indexing): creates a cache with a 
String primary key, triggers the "cannot be fully inlined" warning with an 
update of a row whose key exceeds the default inline size, and asserts via 
`LogListener` that the logged recommendation mentions both 
`IGNITE_MAX_INDEX_PAYLOAD_SIZE` and `CacheConfiguration.sqlIndexMaxInlineSize`.
   
   The test lives in modules/indexing because a running query engine is 
required to build the index; checkstyle passes on both touched modules.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to