alex-plekhanov commented on code in PR #13721:
URL: https://github.com/apache/ignite/pull/13721#discussion_r4336214880
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/EarliestCheckpointMapSnapshot.java:
##########
@@ -17,30 +17,39 @@
package org.apache.ignite.internal.processors.cache.persistence.checkpoint;
+import java.io.Externalizable;
+import java.io.IOException;
+import java.io.ObjectInput;
+import java.io.ObjectOutput;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;
import java.util.UUID;
-import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.dto.IgniteDataTransferObjectInput;
+import org.apache.ignite.internal.dto.IgniteDataTransferObjectOutput;
+import org.apache.ignite.internal.util.typedef.internal.U;
import org.jetbrains.annotations.Nullable;
/**
* Earliest checkpoint map snapshot.
* Speeds up construction of the earliestCp map in the {@link
CheckpointHistory}.
+ *
+ * <b>The snapshot is stored on disk ({@link
CheckpointMarkersStorage#EARLIEST_CP_SNAPSHOT_FILE}),
+ * so its binary format must stay readable across versions.</b>
*/
-public class EarliestCheckpointMapSnapshot extends IgniteDataTransferObject {
+public class EarliestCheckpointMapSnapshot implements Externalizable {
/** Serial version UUID. */
private static final long serialVersionUID = 0L;
+ /** Header magic number. */
Review Comment:
Let's comment here, that MAGIC is the same as IDTO to provide backward
compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
