Vladsz83 commented on code in PR #13686:
URL: https://github.com/apache/ignite/pull/13686#discussion_r4336726337
##########
modules/core/src/main/java/org/apache/ignite/internal/management/cache/VerifyBackupPartitionsTask.java:
##########
@@ -494,32 +483,43 @@ private Future<Map<PartitionKey, PartitionHashRecord>>
calculatePartitionHashAsy
if (!part.reserve())
return res;
+ if (!gctx.offheap().stoppageLock().enterBusy()) {
Review Comment:
My thinking:
1. ignite.context().isStopping() corresponds to the gateway lock acquisition
below.
2. Partitions could be large, and we should be able to cancel fast.
3. We already have the cancellation check at every step, inside the
calculations.
4. The try-catch behavior you’re asking about looks similar to how the GW
lock is implemented. Why do they differ? The GW lock declares an exception,
while BusyLock doesn’t.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
