rezataroosheh opened a new pull request, #13745: URL: https://github.com/apache/ignite/pull/13745
### What changed - When `IGNITE_TO_STRING_INCLUDE_SENSITIVE` is enabled, the warnings now contain `params=[...]`. When it is disabled, parameters are not printed. - H2 engine: LOCAL, MAP, and REDUCE queries. MAP queries print only the parameters used by the map query. - Calcite engine is covered too, since it is now the default engine (IGNITE-29117). - Calcite warning: the `sql='...'` value was missing its closing quote. Fixed, so parameters don't look like part of the SQL text. Example: Long running query is finished [..., sql='SELECT sleep_func(?, 0)', params=[1001], plan=...] ### Notes for review - `IGNITE_TO_STRING_INCLUDE_SENSITIVE` is `true` by default, so parameters are printed by default. This is the same as SQL literals, which are also printed unless the flag is disabled. - Parameters are printed with `S.arrayToString`, so the number of values is limited by `IGNITE_TO_STRING_COLLECTION_LIMIT`. A single value's length is not limited, the same as the `sql` and `plan` parts of the warning. - DML warnings (`H2DmlInfo`) are not changed. ### Tests - `LongRunningQueryTest#testQueryParameters` (H2: LOCAL, MAP, REDUCE) - `SqlDiagnosticIntegrationTest#testLongQueryParametersInLog` (Calcite) Both run with sensitive data enabled and disabled. ### The Contribution Checklist - [x] There is a single JIRA ticket related to the pull request. - [x] The web-link to the pull request is attached to the JIRA ticket. - [x] The JIRA ticket has the _Patch Available_ state. - [x] The pull request body describes changes that have been made. The description explains _WHAT_ and _WHY_ was made instead of _HOW_. - [x] The pull request title is treated as the final commit message. The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue. - [ ] A reviewer has been mentioned through the JIRA comments (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) - [ ] The pull request has been checked by the Teamcity Bot and the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html)) ### Notes - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute) - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules) - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot) If you need any help, please email [email protected] or ask any advice on https://the-asf.slack.com _#ignite_ channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
