zstan commented on code in PR #13741: URL: https://github.com/apache/ignite/pull/13741#discussion_r4376872347
########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. +If these files share a file system, growth in one directory can exhaust the space needed by the others. +A failed write to Ignite data, WAL, or metadata can cause the node to stop. +A full file system can also prevent the node from restarting. + +These recommendations apply to production server nodes. Review Comment: Near recommendations are intended for production server nodes. ########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. Review Comment: It\`s sounds too radical as for me, I think you need to say that concurrent FS usage can produce some spikes thus if exists a possibility to divide\separate File System usage - it need to be done, smth like this .. if I understand u. ########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. +If these files share a file system, growth in one directory can exhaust the space needed by the others. Review Comment: This is obvious case ) No need to describe it as for me ########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. +If these files share a file system, growth in one directory can exhaust the space needed by the others. +A failed write to Ignite data, WAL, or metadata can cause the node to stop. +A full file system can also prevent the node from restarting. Review Comment: "full" - is a just translation but not mean that there is no free space on it. re-phrase it or remove at all. ########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. +If these files share a file system, growth in one directory can exhaust the space needed by the others. +A failed write to Ignite data, WAL, or metadata can cause the node to stop. +A full file system can also prevent the node from restarting. + +These recommendations apply to production server nodes. +For nodes without native persistence, the recommendations for the work directory, logs, and JVM diagnostics still apply. + +Not every role can be isolated: CDC and the root of an incremental snapshot chain are hard-linked to WAL archive segments and therefore have to live on the archive file system. +Isolate the remaining roles. + +== Separate Capacity and I/O + +Use separate file systems or volumes with independently provisioned capacity to contain disk-space exhaustion. +Different directories on the same file system share free space and do not provide this isolation. +A separate file system is a capacity boundary only: it does not by itself reduce I/O contention, which requires a separate device or independently provisioned storage throughput. Review Comment: I think it obvious and need to be removed. ########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. +If these files share a file system, growth in one directory can exhaust the space needed by the others. +A failed write to Ignite data, WAL, or metadata can cause the node to stop. +A full file system can also prevent the node from restarting. + +These recommendations apply to production server nodes. +For nodes without native persistence, the recommendations for the work directory, logs, and JVM diagnostics still apply. Review Comment: ```suggestion On nodes without native persistence, the recommendations for the work directory, logs, and JVM diagnostics still applicable. ``` ########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. +If these files share a file system, growth in one directory can exhaust the space needed by the others. +A failed write to Ignite data, WAL, or metadata can cause the node to stop. +A full file system can also prevent the node from restarting. + +These recommendations apply to production server nodes. +For nodes without native persistence, the recommendations for the work directory, logs, and JVM diagnostics still apply. + +Not every role can be isolated: CDC and the root of an incremental snapshot chain are hard-linked to WAL archive segments and therefore have to live on the archive file system. +Isolate the remaining roles. + +== Separate Capacity and I/O + +Use separate file systems or volumes with independently provisioned capacity to contain disk-space exhaustion. +Different directories on the same file system share free space and do not provide this isolation. +A separate file system is a capacity boundary only: it does not by itself reduce I/O contention, which requires a separate device or independently provisioned storage throughput. + +Separate the roles for a second reason: they compete for the same device queue. +Data files receive checkpoint batches, the active WAL receives the writes of the commit path, and the archive, CDC, and snapshots add their own sequential streams. +When these streams share a device, a spike in one of them delays the others, and the delay appears while the load is at its highest. Review Comment: talk a bit in private, possibly - this is right but sounds very frighteningly without additional details, re-phrase it or remove ########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. +If these files share a file system, growth in one directory can exhaust the space needed by the others. +A failed write to Ignite data, WAL, or metadata can cause the node to stop. +A full file system can also prevent the node from restarting. + +These recommendations apply to production server nodes. +For nodes without native persistence, the recommendations for the work directory, logs, and JVM diagnostics still apply. + +Not every role can be isolated: CDC and the root of an incremental snapshot chain are hard-linked to WAL archive segments and therefore have to live on the archive file system. Review Comment: ```suggestion Not every role can be isolated: CDC and the root of an incremental snapshot chain are hard-linked to WAL archive segments and therefore need to live on the same file system. ``` ########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. +If these files share a file system, growth in one directory can exhaust the space needed by the others. +A failed write to Ignite data, WAL, or metadata can cause the node to stop. +A full file system can also prevent the node from restarting. + +These recommendations apply to production server nodes. +For nodes without native persistence, the recommendations for the work directory, logs, and JVM diagnostics still apply. + +Not every role can be isolated: CDC and the root of an incremental snapshot chain are hard-linked to WAL archive segments and therefore have to live on the archive file system. Review Comment: Or : Not every role can be isolated: CDC and incremental snapshot chain roots are hard-linked to WAL archive segments, so they must reside on the same file system. ########## docs/_docs/server-node-file-system-layout.adoc: ########## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + += Server Node File System Layout + +Plan disk space separately for persistent data, WAL, retained WAL segments, snapshots, logs, and JVM diagnostics. +If these files share a file system, growth in one directory can exhaust the space needed by the others. +A failed write to Ignite data, WAL, or metadata can cause the node to stop. Review Comment: In common - all write operations from Ignite can produce node stop, so you need to re-phrase it like : exhaust free disk space can lead to node stop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
