zstan commented on code in PR #13770:
URL: https://github.com/apache/ignite/pull/13770#discussion_r4441966245
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryHandler.java:
##########
@@ -1734,16 +1735,22 @@ private CacheContinuousQueryEntry
transformToEntry(IgniteClosure<CacheEntryEvent
oldVal = null;
}
+ // The transformer result is not a cache value, so the keep binary
flag of the cache does not apply to it.
+ // Keep it binary only if the transformer returned a BinaryObject, as
on the local node.
+ boolean keepBinary = transVal instanceof BinaryObject;
Review Comment:
look, currently we have :
1. evt.entry().isKeepBinary()
2. keepBinary = transVal instanceof BinaryObject - untipattern at common, I
mean : instanceof for current usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
