Vladsz83 commented on code in PR #13599:
URL: https://github.com/apache/ignite/pull/13599#discussion_r4445504962
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java:
##########
@@ -993,6 +993,31 @@ protected void recordNodeId(UUID nodeId,
AffinityTopologyVersion topVer) {
@Nullable GridCacheVersion dhtVer,
@Nullable Long updateCntr
) throws IgniteCheckedException, GridCacheEntryRemovedException {
+ // Explicit expire time is already reached, the value is expired:
remove the entry instead of storing
+ // an already expired row. A row with expire time in the past must
never be written to the row store,
+ // otherwise the (expireTime, link) pair, already processed by the TTL
cleanup worker, can be recreated
+ // and the pending entries tree becomes inconsistent (see
IGNITE-25194).
+ if (CU.isExpired(drExpireTime)) {
Review Comment:
Is the op changing to DELETE not enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
