XianReallyHot-ZZH commented on code in PR #13737:
URL: https://github.com/apache/ignite/pull/13737#discussion_r4464819200
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java:
##########
@@ -1271,7 +1289,7 @@ private boolean enlistWriteEntry(GridCacheContext
cacheCtx,
if (!implicit &&
cctx.kernalContext().config().isCacheSanityCheckEnabled() &&
entry.lockedByThread(threadId, xidVer)) {
throw new IgniteCheckedException("Cannot access key
within transaction if lock is " +
- "externally held [key=" + CU.value(cacheKey,
cacheCtx, false) +
+ "externally held [key=" + safeKeyValue(cacheKey,
cacheCtx) +
Review Comment:
Done in d0ac711c64 — replaced with `U.toStringSafe(cacheKey)` and removed
the custom helper. Thanks!
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java:
##########
@@ -1506,7 +1524,7 @@ private boolean enlistWriteEntry(GridCacheContext
cacheCtx,
else {
if (entryProc == null && txEntry.op() == TRANSFORM)
throw new IgniteCheckedException("Failed to enlist write value
for key (cannot have update value in " +
- "transaction after EntryProcessor is applied): " +
CU.value(cacheKey, cacheCtx, false));
+ "transaction after EntryProcessor is applied): " +
safeKeyValue(cacheKey, cacheCtx));
Review Comment:
Done in d0ac711c64 — replaced with `U.toStringSafe(cacheKey)` and removed
the custom helper. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]