tkalkirill commented on code in PR #13736:
URL: https://github.com/apache/ignite/pull/13736#discussion_r4471497493
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/AbstractCacheScan.java:
##########
@@ -121,9 +122,22 @@ protected synchronized void reserve() {
GridDhtTopologyFuture topFut = top.topologyVersionFuture();
boolean done = topFut.isDone();
-
- if (!done || !(topFut.topologyVersion().compareTo(topVer) >= 0
- &&
cctx.shared().exchange().lastAffinityChangedTopologyVersion(topFut.initialVersion()).compareTo(topVer)
<= 0)) {
+ AffinityTopologyVersion readyTopVer;
Review Comment:
From a reviewer's perspective, this code might be controversial; I’ll roll
it back if it’s decided that doing so would be beneficial for this ticket.
The point is that, in general, we don’t necessarily have to reject DML
operations if the topology change doesn’t affect the tables involved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]