DenisPolo commented on PR #12584: URL: https://github.com/apache/ignite/pull/12584#issuecomment-6769842466
Responses to the review comments: 1. The `state(MaintenanceTaskState)` method has been removed. The decorator approach has been implemented in MaintenanceProcessor. To implement an internal hook for asynchronous Actions, the interface `AsyncActionStateCallback` has been added, the implementation of which highlights the asynchronous execution. 2. The logic for writing the state has been implemented in the decorator within MaintenanceProcessor. 3. ArrayList has been replaced with `CopyOnWriteArrayList`. In the current implementation, the `lastState()` accessor is no longer required. 4. `IndexCorruptionRebuildTest` has been supplemented with a logging check, as the test already fully implements the required sequence of actions. 5. Fixed, the method now returns a list of objects. 6. Restored the original implementation of the registerWorkflowCallback() method. 7. The `CANCELLED` state implementation has been changed and no longer checks for state transitions, which no longer prevents setting other states. 8. Completely changed. `REGISTERED` and `UNREGISTERED` are now set only for `MaintenanceTask`, while the status change `ACTIVE -> COMPLETED` applies to the executable MaintenanceAction. 9. Replaced with a standard loop. 10. `REGISTERED` and `UNREGISTERED` are set only for `MaintenanceTask`. For executable `MaintenanceAction`, the lifecycle looks as follows: `executedActions=[check=ACTIVE->COMPLETED, clean=ACTIVE]`. The executedActions list preserves the order of actions for which `execute()` is called. 11. 12. 13. Fixed. 14. The functionality of `IgnitePdsDefragmentationTest` has been reused. The PR description has also been filled out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
