NSAmelchev commented on code in PR #13821:
URL: https://github.com/apache/ignite/pull/13821#discussion_r4599876070
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/CoreFeatureRegistry.java:
##########
@@ -114,4 +114,16 @@ public class CoreFeatureRegistry {
/** Feature that introduces the cache size estimation task for SQL
statistics. */
public static final IgniteFeature STATISTICS_CACHE_SIZE_TASK_FEATURE = new
IgniteCoreFeature(5);
+
+ /**
+ * Feature that deprecates {@code
GridDistributedTxFinishRequest#threadId}, {@code
GridNearTxFinishResponse#nearThreadId},
+ * {@code GridNearGetRequest#ver} and {@code GridNearGetResponse#ver}.
+ */
+ public static final IgniteFeature
UNUSED_CACHE_MSG_FIELDS_DEPRECATED_FEATURE = new IgniteCoreFeature(6);
+
+ /** Feature that deprecates {@code
GridDistributedTxFinishRequest#taskNameHash}. */
+ public static final IgniteFeature
TX_FINISH_TASK_NAME_HASH_DEPRECATED_FEATURE = new IgniteCoreFeature(7);
+
+ /** Feature that deprecates {@code GridDhtTxFinishRequest#nearNodeId}. */
+ public static final IgniteFeature
DHT_TX_FINISH_NEAR_NODE_ID_DEPRECATED_FEATURE = new IgniteCoreFeature(8);
Review Comment:
The codegen forbids it: a feature can gate only one field of a message class
hierarchy (`MessageProcessor#checkFeatureGatedFields`, `@Order` javadoc). A raw
field is tagged with the ID of its feature, so two fields of one message under
the same feature would be indistinguishable (IGNITE-29079).
- `GridDhtTxFinishRequest` hierarchy has three such fields (`threadId`,
`taskNameHash`, `nearNodeId`), hence three features.
- Fields of the other hierarchies reuse the first feature, so three is the
minimum.
Lifting the limitation means changing the raw-field format, which is already
in ignite-2.19.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]