anton-vinogradov opened a new pull request, #13854:
URL: https://github.com/apache/ignite/pull/13854

   [IGNITE-29212](https://issues.apache.org/jira/browse/IGNITE-29212) lets HTTP 
REST serve HTTPS from an SSL context factory, so that the TLS reload command 
and automatic hot reload apply to it like to the TCP transports.
   
   ## Configuration
   
   - `ConnectorConfiguration.httpSslFactory` enables HTTPS on the built-in HTTP 
connector or on the connector of the Jetty XML configuration. That connector 
must serve plain HTTP and must not configure TLS itself.
   - `ConnectorConfiguration.httpSslClientAuth` requires a client certificate 
that the factory trusts.
   - The node fails to start before the connector opens if the connector 
configures TLS, if its default protocol is not HTTP, or if `httpSslClientAuth` 
is set without `httpSslFactory`.
   - HTTPS configured directly in Jetty XML keeps working as before and stays 
outside reload.
   
   ## Behavior
   
   - Jetty takes the current context of the factory for each new connection. 
During a reload and after a failed one, new connections use the previous 
context. After a successful reload they use the replacement, and established 
connections stay open.
   - Once HTTP REST has started, it is registered as the `HTTP REST` transport. 
The reload command reports it, and automatic hot reload schedules it when the 
factory supports hot reload and has it enabled. If Jetty cannot bind any port, 
HTTP REST is not registered.
   - Connections enable exactly the protocols and cipher suites that the 
factory enables. Ignite passes them to Jetty as an exact list and clears the 
default exclusions of Jetty, which would otherwise replace the factory settings.
   - Jetty checks the request host against the server certificate unless the 
Jetty XML configuration has a secure request customizer that turns the check 
off.
   - A `LifecycleAware` factory shared by HTTP and binary REST starts and stops 
once per node.
   
   ## API changes
   
   New `ConnectorConfiguration` properties:
   
   ```java
   public Factory<SSLContext> getHttpSslFactory()
   public ConnectorConfiguration setHttpSslFactory(Factory<SSLContext> 
httpSslFactory)
   public boolean isHttpSslClientAuth()
   public ConnectorConfiguration setHttpSslClientAuth(boolean httpSslClientAuth)
   ```
   
   ## Documentation
   
   `restapi.adoc` describes the new settings, the host check, reload, and how 
to move HTTPS from Jetty XML to a factory with a restart. `ssl-tls.adoc` and 
`control-script.adoc` include HTTP REST in manual reload and hot reload.
   
   ## Tests
   
   `JettyRestHttpsTest` runs real nodes and TLS connections. It covers both 
connector configurations, the host check, key and trust rotation with mutual 
TLS, a failed reload, a scheduled renewal with a connection that stays open, 
exact protocols and cipher suites, rejected configurations that never serve 
plain HTTP, unchanged HTTPS from Jetty XML, HTTP REST that did not start, and a 
shared factory lifecycle.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to