anton-vinogradov opened a new pull request, #13867:
URL: https://github.com/apache/ignite/pull/13867

   Adds the **Public behavior changes** check for pull requests to `master`. It 
shows what a pull request changes for Ignite users and where, and fails when 
the [RFC process](https://github.com/apache/ignite/pull/13760) requires an RFC 
that the pull request does not have.
   
   The check builds the target branch and the pull request merged into it, 
lists the public declarations of both builds and compares the lists. Help texts 
and descriptions are not compared, so editing them is not a change. [What the 
check 
compares](https://github.com/anton-vinogradov/ignite/blob/ignite-29326/.github/public-behavior/README.md#what-the-check-compares)
 lists the covered areas and what the reviewer checks.
   
   - **No change.** The check passes, and the bot does not comment.
   - **Only removed deprecated API or changed experimental API.** The check 
passes with a review warning. For a removed deprecated declaration, the warning 
shows when it was deprecated.
   - **A contract change.** The pull request must add or update an RFC file 
named `rfcs/IGNITE-<ticket>-<short-title>.md`, or link an existing RFC file on 
the target branch from its description. With an RFC the check passes with a 
review warning. Without one, or with a misnamed file, it fails.
   - **The check could not finish.** It fails and says whether to fix the pull 
request or rerun the check.
   
   A second workflow posts one comment and replaces it when the result changes. 
It runs on `workflow_run` because the token of a pull request from a fork 
cannot write comments. It never runs pull request code.
   
   Tested on pull requests in a fork with this check on its `master`:
   - [#9](https://github.com/anton-vinogradov/ignite/pull/9): a contract change 
without an RFC, then with a misnamed RFC file.
   - [#10](https://github.com/anton-vinogradov/ignite/pull/10): a removed 
deprecated constant and a new method in experimental API.
   - [#11](https://github.com/anton-vinogradov/ignite/pull/11): a pull request 
that does not compile.
   - [#12](https://github.com/anton-vinogradov/ignite/pull/12): a change to an 
RFC only.
   
   https://issues.apache.org/jira/browse/IGNITE-29326
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to