https://issues.apache.org/bugzilla/show_bug.cgi?id=51822

--- Comment #4 from [email protected] 2011-09-16 21:52:52 UTC ---
(In reply to comment #3)
> (In reply to comment #2)
> > GuiPackage#updateCurrentGui is almost identical to GuiPackage#getCurrentGui
> > except it does not call clearGui
> > 
> > What could be done :
> >   change updateCurrentGui to match getCurrentGui (add clearGui and 
> > try-catch)
> >   change getCurrentGui to simply return the current gui (nothing more)
> > 
> > Some call sites of getCurrentGui rely on the fact it will "save" the current
> > gui
> > eg GuiPackage#localeChanged or JMeterTreeModel#addComponent
> > they must be updated to call updateCurrentGui
> 
> Please raise a separate issue for this.

Hi Sebb

My comment 2 seems out of context...
BUT the change on updateCurrentGui and getCurrentGui is a way to correct this
issue by removing the 'extra work' done in getCurrentGui.

Unless you really want to, I don't think it should be part of another bug

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to