https://issues.apache.org/bugzilla/show_bug.cgi?id=52040
--- Comment #11 from Milamber <[email protected]> 2011-10-23 18:36:44 UTC --- (In reply to comment #10) > I'm not sure it's necessary to have defaults for the icon properties and > toolbar. > If the icons-toolbar.properties file is not found, then JMeter can display an > error box with the details. Done. > > This would simplify the code quite a bit. > > However, it would be useful to be able to override the standard properties > file. > One way to do that is to load it first, and then load the override file (if > any). It's possible with a copy of icon-toolbar.properties and a defined jmeter.toolbar.icons property Allow override only some icon/action: to do later. > > The IconToolbarBean class should probably be immutable; not sure it makes > sense > to allow any of the fields to be changed. Done. > Also, I would probably make it > responsible for resolving the ActionNames fields. Done. > It could also default the > iconPathPressed field to be the same as iconPath, which would simplify the > calling code. Done. > > The code does not affect how tests work, so it can be committed now and > tweaked > later. To do now. Thanks for your comments and suggestions. Milamber -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
