chibenwa commented on a change in pull request #256:
URL: https://github.com/apache/james-project/pull/256#discussion_r510707090



##########
File path: 
server/protocols/webadmin/webadmin-mail-over-web/src/test/resources/json/mail.json
##########
@@ -0,0 +1,13 @@
+{

Review comment:
       > After that i will try to implement the request payload as the 
emailSubmission object.
   
   Don't. I points it to show you this is a complex topic.
   
   I would prefer passing the mail envelope via URL query parameters, and 
having the request payload being the raw MIME message. (I think having the raw 
MIME EML submission format is really easy to use). The client system could be 
as simple as a curl command (good inter-operability, but client system have to 
generate mime messages itself).
   
   If we want to support another format, JSON based, we could use the Accept 
header to specify the Mail to be sent, and could be friendlier to modern 
application (but we won't have a one format fit all use cases without some 
over-engineering - we should rather start with something simple). The client 
system would need to be adapted to this format (limited inter-operability).
   
   I propose you write  an API proposition, with examples, in the JIRA  ticket 
before implementing more things.
   
   (You can of course take care of stylish and location issues).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to