Arsnael commented on a change in pull request #498:
URL: https://github.com/apache/james-project/pull/498#discussion_r654294090
##########
File path:
server/queue/queue-rabbitmq/src/main/java/org/apache/james/queue/rabbitmq/view/cassandra/CassandraMailQueueBrowser.java
##########
@@ -131,6 +131,14 @@ public CassandraMailQueueItemView next() {
.flatMapSequential(slice -> browseSlice(queueName, slice));
}
+ Flux<EnqueuedItemWithSlicingContext> browseReferences(MailQueueName
queueName, Instant start, Instant end) {
+ return allSlicesStartingAt(start)
+ .doOnNext(n -> System.out.println(" --- " + n + " slice looked
up"))
Review comment:
I fixed it, but I do have a concern as I had my hands directly in the
code. This newly created method does not seem to be used anywhere. So did you
forget to switch to it from pieces of code using the other `browseReferences`
method? Or is this useless and should be removed?
##########
File path:
server/queue/queue-rabbitmq/src/main/java/org/apache/james/queue/rabbitmq/view/cassandra/CassandraMailQueueBrowser.java
##########
@@ -131,6 +131,14 @@ public CassandraMailQueueItemView next() {
.flatMapSequential(slice -> browseSlice(queueName, slice));
}
+ Flux<EnqueuedItemWithSlicingContext> browseReferences(MailQueueName
queueName, Instant start, Instant end) {
+ return allSlicesStartingAt(start)
+ .doOnNext(n -> System.out.println(" --- " + n + " slice looked
up"))
Review comment:
cc @chibenwa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
