chibenwa commented on a change in pull request #791:
URL: https://github.com/apache/james-project/pull/791#discussion_r767466176
##########
File path:
protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapSession.java
##########
@@ -233,4 +233,10 @@ default Username getUserName() {
.map(MailboxSession::getUser)
.orElse(null);
}
+
+ default boolean isPlainAuthDisabledEventually() {
Review comment:
Can we try to improve this method name?
Also does this method still make sense when we implement OIDC using IMAP
SASL?
```
Given plainAuth disabled
-> With OIDC and no SSL AUTH should fail
-> With OIDC and SSL auth should succeed
-> With PLAIN and no SSL AUTH should fail
-> With PLAIN and SSL auth should fail
```
The condition is not the case in both case.
Sorry for proposing to factorize code, in the end, given short term
evolutions it likely do not make much sense...
##########
File path:
protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapSession.java
##########
@@ -233,4 +233,10 @@ default Username getUserName() {
.map(MailboxSession::getUser)
.orElse(null);
}
+
+ default boolean isPlainAuthDisabledEventually() {
+ boolean isPlainAuthDisabled = !isPlainAuthEnabled();
Review comment:
```suggestion
isPlainAuthEnabled() -> isSSLRequired()
```
Please dis-ambiguate the code as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
