Arsnael commented on code in PR #1069: URL: https://github.com/apache/james-project/pull/1069#discussion_r908234642
########## server/apps/distributed-app/docs/modules/ROOT/pages/configure/example_french_index.json: ########## @@ -0,0 +1,255 @@ +{ + "settings": { + "number_of_shards": 5, + "number_of_replicas": 1, + "index.write.wait_for_active_shards": 1, + "analysis": { + "normalizer": { + "case_insensitive": { + "type": "custom", + "char_filter": [], + "filter": ["lowercase", "asciifolding"] + } + }, + "analyzer": { + "keep_mail_and_url": { + "tokenizer": "uax_url_email", + "filter": ["lowercase", "stop"] + }, + "keep_mail_and_url_french": { + "tokenizer": "uax_url_email", + "filter": ["lowercase", "french_stop", "french_elision", "french_stemmer"] + }, + "snowball_keep_mail_and_token": { + "tokenizer": "uax_url_email", + "filter": ["lowercase", "stop", "english_snowball"] + } + }, + "tokenizer": {}, + "filter": { + "english_snowball": { + "type": "snowball", + "language": "English" + }, Review Comment: As stated by @quantranhong1999 before it seems english_snowball is declared in the analyzer snowball_keep_mail_and_token that is not used anywhere... I think you should clean up `english_snowball` filter and `snowball_keep_mail_and_token` analyzer though? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org