ottoka commented on PR #1085: URL: https://github.com/apache/james-project/pull/1085#issuecomment-1183492562
Right, it makes sense to ignore exceptions on releaseSession() and just log a warning. My understanding of commons pool is that abandoned objects (not returned to the pool) should be mostly harmless if they are comparatively cheap (like our sessions) and the pool is unbounded. So this holds as well for your second case, e.g. if closeTransport() unexpectedly throws some RuntimeException. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
