Arsnael commented on code in PR #1108:
URL: https://github.com/apache/james-project/pull/1108#discussion_r941971983
##########
third-party/spamassassin/pom.xml:
##########
@@ -84,6 +88,17 @@
<artifactId>james-server-data-memory</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-guice-common</artifactId>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-guice-configuration</artifactId>
+ <version>${james.baseVersion}</version>
Review Comment:
Is this really necessary? Logically you should not have to redeclare
versions here? Idem for other concerned deps in this pom
##########
third-party/spamassassin/pom.xml:
##########
@@ -30,6 +30,10 @@
<name>Apache James :: Third Party :: SpamAssassin</name>
<description>SpamAssassin Java client and testing utilities</description>
+ <properties>
+ <james.baseVersion>${project.version}</james.baseVersion>
Review Comment:
What for? You already have `project.version` available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
